EGNO #602
Merged
EGNO #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiovanniCanali
added
enhancement
Closed
Collaborator
|
Hi! I know it is still draft but I would clean the GitHub history from polluted files. Just add one commit with the modified EGNN and EGNO block |
Collaborator
Hi @dario-coscia! Don't worry, I will take care of it! |
GiovanniCanali
force-pushed
the
avi_egno
branch
3 times, most recently
from
07eafce to
e725e30
Compare
Collaborator
|
@GiovanniCanali Ready for review? |
Collaborator
Almost there! I'll make it ready for review as soon as it is completed. |
GiovanniCanali
force-pushed
the
avi_egno
branch
from
e725e30 to
e019db6
Compare
GiovanniCanali
requested review from
FilippoOlivo,
GiovanniCanali and
dario-coscia
GiovanniCanali
added
pr-to-review
GiovanniCanali
approved these changes
Sep 22, 2025
Collaborator
|
Many thanks to @avisquid for the valuable contribution to this PR. Excellent work! |
GiovanniCanali
added
pr-to-fix
GiovanniCanali
force-pushed
the
avi_egno
branch
from
e019db6 to
77a2317
Compare
GiovanniCanali
force-pushed
the
avi_egno
branch
from
77a2317 to
afc9fac
Compare
GiovanniCanali
force-pushed
the
avi_egno
branch
from
afc9fac to
ac542f6
Compare
GiovanniCanali
added
pr-to-review
dario-coscia
requested changes
Oct 3, 2025
Collaborator
dario-coscia
left a comment
dario-coscia
left a comment
There was a problem hiding this comment.
I reviewed the code, and overall it looks solid. I have a few suggestions:
- Documentation: We should add more details about the input shapes for clarity.
- EGNN implementation with velocity: This part might need a closer look to ensure correctness.
- EGNO: Looks very good. We could experiment with adding more PINA blocks, especially considering the note about temporal spectral convolution.
pina/model/block/message_passing/equivariant_graph_neural_operator_block.py
Show resolved
Hide resolved
pina/model/block/message_passing/equivariant_graph_neural_operator_block.py
Show resolved
Hide resolved
GiovanniCanali
force-pushed
the
avi_egno
branch
from
ac542f6 to
0964918
Compare
Co-authored-by: avisquid <[email protected]>
GiovanniCanali
force-pushed
the
avi_egno
branch
from
0964918 to
0316208
Compare
dario-coscia
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the Equivariant Graph Neural Operator
This PR fixes #616
Checklist